feat: send l1infotree data to the aggchain prover
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
requested review from
joanestebanr,
vcastellm and
Stefan-Ethernal
Stefan-Ethernal
approved these changes
Feb 5, 2025
joanestebanr
reviewed
Feb 5, 2025
To be consistent. It is useful for debugging, if we have issues on other syncers with reorg detection. |
joanestebanr
reviewed
Feb 5, 2025
|
joanestebanr
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the additional logic of sending
l1infotreedata to theaggchain proverthat is needed to generate aaggchain(auth) proof.The data includes:
l1InfoTreeRoot.l1infoTreeRoot.Based on the provided block range and on the finalized l1 info tree data we send to the prover, prover can either return the maximum block range we asked, or return a smaller range.
But, in order to do this, all the syncers need to store block hash as well to the block table. Before this PR, only
l1infotreesyncerstored this data, but we might need it in all syncers (to be consistent), so this PR expanded all the syncers to store the block hash as well.Fixes # (issue)